[haiku-commits] Re: r35409 - haiku/trunk/src/apps/mediaplayer/playlist

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 05 Feb 2010 07:41:26 +0100

On 2010-02-05 at 01:55:33 [+0100], stpere@xxxxxxxxx wrote:
> Author: stpere
> Date: 2010-02-05 01:55:33 +0100 (Fri, 05 Feb 2010) New Revision: 35409
> Changeset: http://dev.haiku-os.org/changeset/35409/haiku Ticket: 
> http://dev.haiku-os.org/ticket/3199
> 
> Modified:
>    haiku/trunk/src/apps/mediaplayer/playlist/ListViews.cpp
> Log:
> MediaPlayer Playlist:
> 
>  * Reset the DropIndex when the drag is exiting the window.
>  * Otherwise, the anticipation rect isn't set back on when you enter 
>  again the window.
> 
> Fixes ticket #3199.
> 
> 
> Modified: haiku/trunk/src/apps/mediaplayer/playlist/ListViews.cpp 
> ===================================================================
> --- haiku/trunk/src/apps/mediaplayer/playlist/ListViews.cpp    2010-02-04 
> 20:40:35 UTC (rev 35408)
> +++ haiku/trunk/src/apps/mediaplayer/playlist/ListViews.cpp    2010-02-05 
> 00:55:33 UTC (rev 35409)
> @@ -815,7 +815,7 @@
>  DragSortableListView::_RemoveDropAnticipationRect() {
>      _SetDropAnticipationRect(BRect(0.0, 0.0, -1.0, -1.0));
> -//    _SetDropIndex(-1);
> +    _SetDropIndex(-1);
>  }

There has got to be a reason why I commented that out. Are you sure the 
drop index is still what it is supposed to be when drag sorting items now?

Best regards,
-Stephan

Other related posts: