[haiku-commits] Re: r35302 - haiku/trunk/src/apps/mediaplayer
- From: Stephan Assmus <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 27 Jan 2010 06:28:19 +0100
On 2010-01-26 at 23:50:10 [+0100], Michael Lotz <mmlr@xxxxxxxx> wrote:
> >
> > On 2010-01-26 at 22:23:33 [+0100], mmlr@xxxxxxxx wrote:
> > > Author: mmlr
> > > Date: 2010-01-26 22:23:33 +0100 (Tue, 26 Jan 2010) New Revision:
> > > 35302
> > > Changeset: http://dev.haiku-os.org/changeset/35302/haiku
> > >
> > > Modified:
> > > haiku/trunk/src/apps/mediaplayer/MainWin.cpp
> > > Log:
> > > Add "URI" property that returns the URI of the currently playing item.
> >
> > I am not sure how I setup the locking there anymore. Did you check that
> > you
> > don't need an auto locker for the playlist?
>
> I'm not sure. In _SetFileAttributes() it doesn't seem to lock either. The
> calling function uses an autolock on the playlist, but it's not held at
> the time of calling anymore. In the info window the controller get's
> locked while all the info is retrieved though. Would either of these
> methods work?
Thanks for checking! In theory, the user could mess with the playlist from
within the playlist window. So anywhere the playlist is accessed without
holding the lock is incorrect.
Best regards,
-Stephan
Other related posts:
