[haiku-commits] Re: r35055 - haiku/trunk/src/kits/tracker

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 13 Jan 2010 23:47:44 +0100

On 2010-01-13 at 18:28:43 [+0100], Rene Gollent <anevilyak@xxxxxxxxx> wrote:
> On Wed, Jan 13, 2010 at 11:20 AM,  <superstippi@xxxxxx> wrote:
> > Author: stippi
> > Date: 2010-01-13 18:20:01 +0100 (Wed, 13 Jan 2010) New Revision: 35055
> > Changeset: http://dev.haiku-os.org/changeset/35055/haiku
> >
> > Modified:
> >   haiku/trunk/src/kits/tracker/FSUtils.cpp
> >   haiku/trunk/src/kits/tracker/FSUtils.h
> > Log:
> >  * First attempt at cleaning up the CopyLoopControl mess. Instantiate 
> >  one
> >   TrackerCopyLoopControl and pass it on when needed. Avoid access to 
> >   gStatusWindow directly. Later on, I will try to make it possible to 
> >   drop more files/folders onto an ongoing copy process to append it to 
> >   the job, i.e. copy those files to the same target folder.
> >  * For each updating the status, entry_refs were copied instead of 
> >  passed by
> >   reference, which was a bit unnecessary overhead.
> 
> Nice :) I don't suppose anything you're doing with this work 
> overlaps/covers ticket #3171 does it?

Looked at the ticket and no, I didn't really have any plans to make 
prompting more fine grained :-). However, more cleanup in FSUtils may make 
it a lot easier to tweak that code. In general I wouldn't mind more 
information in the job status. Like how fast it currently performs and how 
much time it thinks it will still take.

Best regards,
-Stephan

Other related posts: