[haiku-commits] r34915 - haiku/trunk/src/add-ons/kernel/drivers/input/wacom
- From: mmlr@xxxxxxxx
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 6 Jan 2010 01:54:16 +0100 (CET)
Author: mmlr
Date: 2010-01-06 01:54:15 +0100 (Wed, 06 Jan 2010)
New Revision: 34915
Changeset: http://dev.haiku-os.org/changeset/34915/haiku
Ticket: http://dev.haiku-os.org/ticket/4604
Modified:
haiku/trunk/src/add-ons/kernel/drivers/input/wacom/wacom.c
Log:
I don't know why this was disabled, but not canceling the queued transfers after
a timeout leaks these transfers. In the end this would at least lead to a flood
of canceled transfers on device unplug or, worse yet, exhaust the USB memory
pool stalling all further transfers as seen in #4604. Probably fixes both
issues, can't test though as I don't have the hardware.
Modified: haiku/trunk/src/add-ons/kernel/drivers/input/wacom/wacom.c
===================================================================
--- haiku/trunk/src/add-ons/kernel/drivers/input/wacom/wacom.c 2010-01-06
00:48:13 UTC (rev 34914)
+++ haiku/trunk/src/add-ons/kernel/drivers/input/wacom/wacom.c 2010-01-06
00:54:15 UTC (rev 34915)
@@ -547,7 +547,7 @@
B_RELATIVE_TIMEOUT, 500 * 1000);
// handle time out
if (ret < B_OK) {
-//
usb->cancel_queued_transfers(device->pipe);
+
usb->cancel_queued_transfers(device->pipe);
if (ret == B_TIMED_OUT) {
// a time_out is ok, since it
only means that the device
// had nothing to report (ie
mouse/pen was not moved)
Other related posts:
