[haiku-commits] Re: r34850 - haiku/trunk/src/system/boot/platform/openfirmware
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 03 Jan 2010 14:33:19 +0100
Stephan Assmus <superstippi@xxxxxx> wrote:
> On 2010-01-02 at 10:50:30 [+0100], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
> > wrote:
> > superstippi@xxxxxx wrote:
> > > +parse_ip_address_component(const char *sz, int len)
> > > +{
> > > + const int base = 10;
> > Coding style: Don't use cryptic variable names like "sz" or "psz"
> > as
> > below.
> > const variables usually get a 'k' prefix.
> I pondered changing the variable names, but these are really very
> basic and
> short functions and it is pretty clear what is what, so I left them
> be. ;-)
> Do you really want me to change them or did you only skim the commit?
There were some more optimization/cleaning opportunities, that I applied
in r34870.
Bye,
Axel.
Other related posts:
