[haiku-commits] Re: r34679 - haiku/trunk/src/system/boot/loader

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 30 Dec 2009 15:58:01 +0100

On 2009-12-15 at 23:19:08 [+0100], fredrik.holmqvist@xxxxxxxxx wrote:
> Author: tqh
> Date: 2009-12-15 23:19:08 +0100 (Tue, 15 Dec 2009)
> New Revision: 34679
> Changeset: http://dev.haiku-os.org/changeset/34679/haiku
> 
> Modified:
>    haiku/trunk/src/system/boot/loader/elf.cpp
> Log:
> Make sure settings isn't null. Not my finest day apparently.

Clearly not. If you work with unfamiliar code, please at least test your 
changes. Particularly when all that is to do is trying both states of a 
boolean setting. You would have noticed that the driver settings can't be 
loaded at that point.

Furthermore the boot loader only loads the modules potentially relevant for 
booting (getting to the point where the boot volume is mounted that is). 
The others are loaded by the kernel. The setting should obviously also be 
evaluted there.

I've re-enabled unconditional loading of the debug symbols in r34825. Feel 
free to find a solution that works.

CU, Ingo

Other related posts: