[haiku-commits] Re: r34140 - haiku/trunk/src/apps/screenshot
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 20 Nov 2009 09:34:15 +0100
Fredrik Modèen <fredrik@xxxxxxxxx> wrote:
> > Can you elaborate on that? It looks a bit like you have hard-coded
> > values
> > that depend on the runtime configuration of currently installed
> > translators.
> Yes I have and if there are a better way please tell me :)
> I actually had int values (taken with a printf) instead of the define
> values like B_PNG_FORMAT.
You are really serious? How do you think this could have ever worked
for real?
Please, if you are unsure about something, don't commit completely
broken stuff like this -- just ask how one could do it. No one would
mind to answer a question like this.
You could have a look at src/bin/translate.cpp which more or less solves
the same thing a bit more intelligently and flexible.
Bye,
Axel.
Other related posts:
