[haiku-commits] Re: r34140 - haiku/trunk/src/apps/screenshot

  • From: Fredrik Modèen <fredrik@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 19 Nov 2009 22:41:03 +0100 (CET)

> 2009/11/19  <fredrik@xxxxxxxxx>:
>> -BString
>> +const char*
>>  ScreenshotWindow::_FindValidFileName(const char* name)
>>  {
>>        BString baseName(name);
>> -
> ...
>>
>> -       if (!fLastSelectedPath)
>> +       if (!fSaveScreenshotSilent && !fLastSelectedPath)
>>                return baseName;
>
> Here it seems the method now returns a pointer to a stack allocated
> buffer, which doesn't look correct.
Yes and no it's not correct, thanks

>
> Bye,
> Jérôme
>
>


-- 
MVH
Fredrik Modèen


Other related posts: