2009/10/27, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>: > philippe.houdoin@xxxxxxxxx wrote: > > + return info.protection & B_KERNEL_READ_AREA && > > + (pointer + length) <= (info.address + info.ram_size); > > > While the parenthesis around "pointer + length" are superfluous, there > are some parenthesis missing around info.protection & ... > To reduce those errors, please always write (a & b) != 0. > Just another thing I will put into the coding style. > > Bye, > > Axel. My bad. Also the check for both read and write is not right as well. (It actually checks if it's either readable, writable or both atm. Instead of it being readable and writable). /Fredrik Holmqvist, TQH