[haiku-commits] Re: r33766 - haiku/trunk/src/kits/interface

  • From: Brecht Machiels <brecht@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 25 Oct 2009 23:27:33 +0000

axeld@xxxxxxxxxxxxxxxx wrote:
Author: axeld
Date: 2009-10-25 22:26:54 +0100 (Sun, 25 Oct 2009)
New Revision: 33766
Changeset: http://dev.haiku-os.org/changeset/33766/haiku

* Fixed lots of style violations, many of them introduced with r33732.

Hey, that's not fair! I count only three by me.

* Brecht, is it possible your line break column is one character too short? At
  least you broke some lines without need.

I might have wrapped some 'at sight'. Will watch out for that.

        if (reply.FindData("key_buffer", B_ANY_TYPE, &key_array, 
-               != B_OK) {
+                       != B_OK) {
                *map = 0; *key_buffer = 0;

I've been wanting to indent an extra tab under an if to make it more clear that it it not part of the if body. The coding guidelines only ever show one tab however, which is what I stuck to.

The /*! comment is not discussed in the coding guidelines.


Other related posts: