[haiku-commits] Re: [haiku-commits] Re: r38174 -=D=A haiku/trunk/src/apps/icon-o-matic/import_export/styled_text
- From: pulkomandy <pulkomandy@xxxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 17 Aug 2010 12:12:45 +0200
> >+ if (shape == NULL)
> >+ return B_NO_MEMORY;
> > shape->SetName(glyphName.String());
> >- if (!shape || !icon->Shapes()->AddShape(shape)) {
> >+ if (!icon->Shapes()->AddShape(shape)) {
> > delete shape;
> > return B_NO_MEMORY;
> > }
>
> The simpler fix would have been to move the SetName() line below the
> existing checks. :-)
I was not sure it would get added to the icon with the new name and too
lazy to check.
--
Adrien.
Other related posts:
- » [haiku-commits] Re: [haiku-commits] Re: r38174 -=D=A haiku/trunk/src/apps/icon-o-matic/import_export/styled_text - pulkomandy
