hrev56128 adds 1 changeset to branch 'master'
old head: eb9ff8e5a795ffe1a087dd133df3502df6e5ab13
new head: 7d137fd96abff40353334bd707cf506922c6f272
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=7d137fd96abf+%5Eeb9ff8e5a795
----------------------------------------------------------------------------
7d137fd96abf: HaikuDepot: Issue with Version Dates
Resolves an issue where package version dates are not
updated in the UI as they are updated in the model.
Change-Id: Ic21954f91abb9c6f9bf0907500e189215adb70de
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5333
Tested-by: Commit checker robot <no-reply+buildbot@xxxxxxxxxxxx>
Reviewed-by: Jérôme Duval <jerome.duval@xxxxxxxxx>
[ Andrew Lindesay <apl@xxxxxxxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev56128
Commit: 7d137fd96abff40353334bd707cf506922c6f272
URL: https://git.haiku-os.org/haiku/commit/?id=7d137fd96abf
Author: Andrew Lindesay <apl@xxxxxxxxxxxxxx>
Date: Mon May 23 10:51:04 2022 UTC
----------------------------------------------------------------------------
3 files changed, 23 insertions(+), 16 deletions(-)
src/apps/haikudepot/model/PackageInfo.cpp | 7 ++++--
src/apps/haikudepot/model/PackageInfoListener.h | 28 +++++++++++----------
src/apps/haikudepot/ui/PackageListView.cpp | 4 ++-
----------------------------------------------------------------------------
diff --git a/src/apps/haikudepot/model/PackageInfo.cpp
b/src/apps/haikudepot/model/PackageInfo.cpp
index 4af86b94c5..9a6044ef7c 100644
--- a/src/apps/haikudepot/model/PackageInfo.cpp
+++ b/src/apps/haikudepot/model/PackageInfo.cpp
@@ -1,7 +1,7 @@
/*
* Copyright 2013-2014, Stephan Aßmus <superstippi@xxxxxx>.
* Copyright 2013, Rene Gollent <rene@xxxxxxxxxxx>.
- * Copyright 2016-2021, Andrew Lindesay <apl@xxxxxxxxxxxxxx>.
+ * Copyright 2016-2022, Andrew Lindesay <apl@xxxxxxxxxxxxxx>.
* All rights reserved. Distributed under the terms of the MIT License.
*/
@@ -1016,7 +1016,10 @@ PackageInfo::SetViewed()
void
PackageInfo::SetVersionCreateTimestamp(uint64 value)
{
- fVersionCreateTimestamp = value;
+ if (fVersionCreateTimestamp != value) {
+ fVersionCreateTimestamp = value;
+ _NotifyListeners(PKG_CHANGED_VERSION_CREATE_TIMESTAMP);
+ }
}
diff --git a/src/apps/haikudepot/model/PackageInfoListener.h
b/src/apps/haikudepot/model/PackageInfoListener.h
index 7ff8fbe7f9..97e2003ee7 100644
--- a/src/apps/haikudepot/model/PackageInfoListener.h
+++ b/src/apps/haikudepot/model/PackageInfoListener.h
@@ -1,5 +1,6 @@
/*
* Copyright 2013, Stephan Aßmus <superstippi@xxxxxx>.
+ * Copyright 2022, Andrew Lindesay <apl@xxxxxxxxxxxxxx>.
* All rights reserved. Distributed under the terms of the MIT License.
*/
#ifndef PACKAGE_INFO_LISTENER_H
@@ -10,19 +11,20 @@
enum {
- PKG_CHANGED_TITLE = 1 << 0,
- PKG_CHANGED_SUMMARY = 1 << 1,
- PKG_CHANGED_DESCRIPTION = 1 << 2,
- PKG_CHANGED_RATINGS = 1 << 3,
- PKG_CHANGED_SCREENSHOTS = 1 << 4,
- PKG_CHANGED_STATE = 1 << 5,
- PKG_CHANGED_ICON = 1 << 6,
- PKG_CHANGED_CHANGELOG = 1 << 7,
- PKG_CHANGED_CATEGORIES = 1 << 8,
- PKG_CHANGED_PROMINENCE = 1 << 9,
- PKG_CHANGED_SIZE = 1 << 10,
- PKG_CHANGED_DEPOT = 1 << 11,
- PKG_CHANGED_VERSION = 1 << 12
+ PKG_CHANGED_TITLE = 1 <<
0,
+ PKG_CHANGED_SUMMARY = 1 <<
1,
+ PKG_CHANGED_DESCRIPTION = 1 << 2,
+ PKG_CHANGED_RATINGS = 1 <<
3,
+ PKG_CHANGED_SCREENSHOTS = 1 << 4,
+ PKG_CHANGED_STATE = 1 <<
5,
+ PKG_CHANGED_ICON = 1 <<
6,
+ PKG_CHANGED_CHANGELOG = 1 << 7,
+ PKG_CHANGED_CATEGORIES = 1 << 8,
+ PKG_CHANGED_PROMINENCE = 1 << 9,
+ PKG_CHANGED_SIZE = 1 <<
10,
+ PKG_CHANGED_DEPOT = 1 <<
11,
+ PKG_CHANGED_VERSION = 1 <<
12,
+ PKG_CHANGED_VERSION_CREATE_TIMESTAMP = 1 << 13
// ...
};
diff --git a/src/apps/haikudepot/ui/PackageListView.cpp
b/src/apps/haikudepot/ui/PackageListView.cpp
index fe22dee5ae..ebf78e7df3 100644
--- a/src/apps/haikudepot/ui/PackageListView.cpp
+++ b/src/apps/haikudepot/ui/PackageListView.cpp
@@ -1,5 +1,5 @@
/*
- * Copyright 2018-2021, Andrew Lindesay, <apl@xxxxxxxxxxxxxx>.
+ * Copyright 2018-2022, Andrew Lindesay, <apl@xxxxxxxxxxxxxx>.
* Copyright 2017, Julian Harnath, <julian.harnath@xxxxxxxxxxxxxx>.
* Copyright 2015, Axel Dörfler, <axeld@xxxxxxxxxxxxxxxx>.
* Copyright 2013-2014, Stephan Aßmus <superstippi@xxxxxx>.
@@ -966,6 +966,8 @@ PackageListView::MessageReceived(BMessage* message)
row->UpdateRepository();
if ((changes & PKG_CHANGED_VERSION) != 0)
row->UpdateVersion();
+ if ((changes &
PKG_CHANGED_VERSION_CREATE_TIMESTAMP) != 0)
+ row->UpdateVersionCreateTimestamp();
}
break;
}
