[haiku-commits] haiku: hrev54886 - src/add-ons/kernel/drivers/disk/mmc

  • From: Adrien Destugues <pulkomandy@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 12 Jan 2021 16:50:15 -0500 (EST)

hrev54886 adds 1 changeset to branch 'master'
old head: f8650bc2db0e87d9577f109bf92d6256ebafff0a
new head: 2aa5a0353de1a64683667938553cd01dc8706ddc
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=2aa5a0353de1+%5Ef8650bc2db0e

----------------------------------------------------------------------------

2aa5a0353de1: mmc_disk: disable currently non working code
  
  Switching to 4 bit mode requires some more coordination as the host
  controller must also be switched, right after sending this command.
  
  I will revisit this, but the previous commit was accidentally pushed to
  master.
  
  At least we get the 25MHz clock instead of 400kHz, that should already
  be quite a performance improvement.

                             [ Adrien Destugues <pulkomandy@xxxxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev54886
Commit:      2aa5a0353de1a64683667938553cd01dc8706ddc
URL:         https://git.haiku-os.org/haiku/commit/?id=2aa5a0353de1
Author:      Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Date:        Tue Jan 12 21:47:58 2021 UTC

----------------------------------------------------------------------------

1 file changed, 2 insertions(+)
src/add-ons/kernel/drivers/disk/mmc/mmc_disk.cpp | 2 ++

----------------------------------------------------------------------------

diff --git a/src/add-ons/kernel/drivers/disk/mmc/mmc_disk.cpp 
b/src/add-ons/kernel/drivers/disk/mmc/mmc_disk.cpp
index 8fc2ca49f0..c80d7fc444 100644
--- a/src/add-ons/kernel/drivers/disk/mmc/mmc_disk.cpp
+++ b/src/add-ons/kernel/drivers/disk/mmc/mmc_disk.cpp
@@ -170,6 +170,7 @@ mmc_block_get_geometry(mmc_disk_driver_info* info, 
device_geometry* geometry)
        geometry->read_only = false; // TODO check write protect switch?
        geometry->write_once = false;
 
+#if 0
        // This function will be called before all data transfers, so we use 
this
        // opportunity to switch the card to 4-bit data transfers (instead of 
the
        // default 1 bit mode)
@@ -179,6 +180,7 @@ mmc_block_get_geometry(mmc_disk_driver_info* info, 
device_geometry* geometry)
                info->rca << 16, &cardStatus);
        info->mmc->execute_command(info->parent, info->rca, SD_SET_BUS_WIDTH,
                k4BitMode, &cardStatus);
+#endif
 
        return B_OK;
 }


Other related posts:

  • » [haiku-commits] haiku: hrev54886 - src/add-ons/kernel/drivers/disk/mmc - Adrien Destugues