[haiku-commits] haiku: hrev54677 - src/apps/packageinstaller

  • From: Jérôme Duval <jerome.duval@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 23 Oct 2020 03:49:56 -0400 (EDT)

hrev54677 adds 1 changeset to branch 'master'
old head: f7fbc22a58495aa6ebc5fb21a9015116c7af581b
new head: fb4fd84f4dcd4ee910143eb46c600fe2b842d142
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=fb4fd84f4dcd+%5Ef7fbc22a5849

----------------------------------------------------------------------------

fb4fd84f4dcd: packageinstaller: Fix -Wformat-security
  
  Change-Id: I9792b89ed0b59d509f20c43170f806a6168cbf81
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/3347
  Reviewed-by: Jérôme Duval <jerome.duval@xxxxxxxxx>

                                      [ Murai Takashi <tmurai01@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev54677
Commit:      fb4fd84f4dcd4ee910143eb46c600fe2b842d142
URL:         https://git.haiku-os.org/haiku/commit/?id=fb4fd84f4dcd
Author:      Murai Takashi <tmurai01@xxxxxxxxx>
Date:        Thu Oct 15 09:34:54 2020 UTC
Committer:   Jérôme Duval <jerome.duval@xxxxxxxxx>
Commit-Date: Fri Oct 23 07:49:53 2020 UTC

----------------------------------------------------------------------------

1 file changed, 4 insertions(+), 4 deletions(-)
src/apps/packageinstaller/PackageView.cpp | 8 ++++----

----------------------------------------------------------------------------

diff --git a/src/apps/packageinstaller/PackageView.cpp 
b/src/apps/packageinstaller/PackageView.cpp
index 9cdf1cc0c4..9614106017 100644
--- a/src/apps/packageinstaller/PackageView.cpp
+++ b/src/apps/packageinstaller/PackageView.cpp
@@ -223,8 +223,8 @@ PackageView::MessageReceived(BMessage* message)
                                        "distributor."),
                                B_TRANSLATE("OK"),
                                NULL, NULL, B_WIDTH_AS_USUAL, B_WARNING_ALERT);
-                       fprintf(stderr,
-                               B_TRANSLATE("Error while installing the 
package\n"));
+                       fputs(B_TRANSLATE("Error while installing the 
package\n"),
+                               stderr);
                        notify->SetFlags(notify->Flags() | B_CLOSE_ON_ESCAPE);
                        notify->Go();
                        fStatusWindow->Hide();
@@ -390,7 +390,7 @@ PackageView::ItemExists(PackageItem& item, BPath& path, 
int32& policy)
                                // TODO: Maybe add 'No, but ask again' type of 
choice as well?
                                alertString = B_TRANSLATE("Do you want to 
remember this "
                                        "decision for the rest of this 
installation?\n");
-                               
+
                                BString actionString;
                                if (choice == P_EXISTS_OVERWRITE) {
                                        alertString << B_TRANSLATE(
@@ -645,7 +645,7 @@ PackageView::_InstallTypeChanged(int32 index)
 
                        char volumeName[B_FILE_NAME_LENGTH];
                        volume.GetName(volumeName);
-       
+
                        BMenuItem* item = _AddDestinationMenuItem(volumeName,
                                volume.FreeBytes(), path.Path());
 


Other related posts:

  • » [haiku-commits] haiku: hrev54677 - src/apps/packageinstaller - Jérôme Duval