hrev54289 adds 1 changeset to branch 'master'
old head: 6b0e92ebd4c131c7b0cc3350ac14e55cf9062445
new head: 16f2f8eb8109b35c2151baa05afcfd15875077a5
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=16f2f8eb8109+%5E6b0e92ebd4c1
----------------------------------------------------------------------------
16f2f8eb8109: HaikuDepot: Contents for Local Pkg (b)
Fixes a bug where contents are not displayed
for local files that are not installed.
Resolves #16161
Change-Id: I27abfd78bf7882b1961f8d9c6ade30d4c15ec2ad
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2865
Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>
[ Andrew Lindesay <apl@xxxxxxxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev54289
Commit: 16f2f8eb8109b35c2151baa05afcfd15875077a5
URL: https://git.haiku-os.org/haiku/commit/?id=16f2f8eb8109
Author: Andrew Lindesay <apl@xxxxxxxxxxxxxx>
Date: Tue Jun 2 06:20:19 2020 UTC
Committer: waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Tue Jun 2 23:02:29 2020 UTC
Ticket: https://dev.haiku-os.org/ticket/16161
----------------------------------------------------------------------------
1 file changed, 5 insertions(+), 3 deletions(-)
src/apps/haikudepot/ui/PackageContentsView.cpp | 8 +++++---
----------------------------------------------------------------------------
diff --git a/src/apps/haikudepot/ui/PackageContentsView.cpp
b/src/apps/haikudepot/ui/PackageContentsView.cpp
index 0a29ce0fec..3fa151cb08 100644
--- a/src/apps/haikudepot/ui/PackageContentsView.cpp
+++ b/src/apps/haikudepot/ui/PackageContentsView.cpp
@@ -302,11 +302,13 @@ PackageContentsView::SetPackage(const PackageInfoRef&
package)
fLastPackageState = package.Get() != NULL ? package->State() :
NONE;
}
- // if the package is not installed then there is no point in attempting
to
- // populate data for it.
+ // if the package is not installed and is not a local file on disk then
+ // there is no point in attempting to populate data for it.
- if (package.Get() != NULL && package->State() == ACTIVATED)
+ if (package.Get() != NULL
+ && (package->State() == ACTIVATED ||
package->IsLocalFile())) {
release_sem_etc(fContentPopulatorSem, 1, 0);
+ }
}
