hrev53843 adds 1 changeset to branch 'master'
old head: d029e65f6f62eb8c7f10b48adbd829b866702420
new head: 2e37c88d2bb25ef8cd614ef7a5489152227dc9f5
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=2e37c88d2bb2+%5Ed029e65f6f62
----------------------------------------------------------------------------
2e37c88d2bb2: haikudepot: Fix 'new[]' array freed with 'delete'
buffer is allocated by new[] in _UnpackCaptcha(), but freed by delete.
Pointed out by LGTM.
Change-Id: I6feee3f9791950c33bbc2037c7809e21f250fa47
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2226
Reviewed-by: Jérôme Duval <jerome.duval@xxxxxxxxx>
[ Murai Takashi <tmurai01@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev53843
Commit: 2e37c88d2bb25ef8cd614ef7a5489152227dc9f5
URL: https://git.haiku-os.org/haiku/commit/?id=2e37c88d2bb2
Author: Murai Takashi <tmurai01@xxxxxxxxx>
Date: Fri Feb 7 21:19:13 2020 UTC
Committer: waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Sat Feb 8 16:35:11 2020 UTC
----------------------------------------------------------------------------
1 file changed, 1 insertion(+), 1 deletion(-)
src/apps/haikudepot/ui/UserLoginWindow.cpp | 2 +-
----------------------------------------------------------------------------
diff --git a/src/apps/haikudepot/ui/UserLoginWindow.cpp
b/src/apps/haikudepot/ui/UserLoginWindow.cpp
index 643d40fcf4..f879c4f8cb 100644
--- a/src/apps/haikudepot/ui/UserLoginWindow.cpp
+++ b/src/apps/haikudepot/ui/UserLoginWindow.cpp
@@ -875,7 +875,7 @@ UserLoginWindow::_UnpackCaptcha(BMessage& responsePayload,
Captcha& captcha)
captcha.SetToken(token);
captcha.SetPngImageData(buffer, decodedSize);
}
- delete buffer;
+ delete[] buffer;
}
return result;
