[haiku-commits] haiku: hrev53827 - src/system/runtime_loader

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 5 Feb 2020 19:11:14 -0500 (EST)

hrev53827 adds 1 changeset to branch 'master'
old head: a206dcc221e781aa6c03631de1fc4da9b146a880
new head: 24ffd29c7dcd23552ad6d482fb3b9b16c776bd29
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=24ffd29c7dcd+%5Ea206dcc221e7

----------------------------------------------------------------------------

24ffd29c7dcd: runtime_loader: Fix PVS V595
  
  Add NULL check for fValuesResolved, since malloc() might
  return NULL.
  
  Change-Id: I3849ddfcffd7712fec3d90546244c6b17e4d0f77
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/2202
  Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>

                                      [ Murai Takashi <tmurai01@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev53827
Commit:      24ffd29c7dcd23552ad6d482fb3b9b16c776bd29
URL:         https://git.haiku-os.org/haiku/commit/?id=24ffd29c7dcd
Author:      Murai Takashi <tmurai01@xxxxxxxxx>
Date:        Tue Jan 28 11:21:09 2020 UTC
Committer:   waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Thu Feb  6 00:11:06 2020 UTC

----------------------------------------------------------------------------

1 file changed, 2 insertions(+), 1 deletion(-)
src/system/runtime_loader/elf_symbol_lookup.h | 3 ++-

----------------------------------------------------------------------------

diff --git a/src/system/runtime_loader/elf_symbol_lookup.h 
b/src/system/runtime_loader/elf_symbol_lookup.h
index f3f031b40f..dbe5251c72 100644
--- a/src/system/runtime_loader/elf_symbol_lookup.h
+++ b/src/system/runtime_loader/elf_symbol_lookup.h
@@ -69,7 +69,8 @@ struct SymbolLookupCache {
 
                        size_t elementCount = (fTableSize + 31) / 32;
                        fValuesResolved = (uint32*)malloc(4 * elementCount);
-                       memset(fValuesResolved, 0, 4 * elementCount);
+                       if (fValuesResolved != NULL)
+                               memset(fValuesResolved, 0, 4 * elementCount);
 
                        if (fValues == NULL || fDSOs == NULL || fValuesResolved 
== NULL) {
                                free(fValuesResolved);


Other related posts:

  • » [haiku-commits] haiku: hrev53827 - src/system/runtime_loader - waddlesplash