hrev53795 adds 1 changeset to branch 'master'
old head: 958d3f437574cefaf8831b29430b2cfa9e508052
new head: f67a67798629a4b6d67219efe919b3c827fa32ab
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=f67a67798629+%5E958d3f437574
----------------------------------------------------------------------------
f67a67798629: soundrecorder: Fix PVS V595
Add NULL check for 'fBitmap', since it might be NULL
at line 71.
Change-Id: I70bf4d29e20bbe1c62d972f576dc52d4783933d1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2169
Reviewed-by: Jérôme Duval <jerome.duval@xxxxxxxxx>
[ Murai Takashi <tmurai01@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev53795
Commit: f67a67798629a4b6d67219efe919b3c827fa32ab
URL: https://git.haiku-os.org/haiku/commit/?id=f67a67798629
Author: Murai Takashi <tmurai01@xxxxxxxxx>
Date: Sun Jan 26 11:23:16 2020 UTC
Committer: Jérôme Duval <jerome.duval@xxxxxxxxx>
Commit-Date: Fri Jan 31 11:46:42 2020 UTC
----------------------------------------------------------------------------
1 file changed, 7 insertions(+), 6 deletions(-)
src/apps/soundrecorder/TrackSlider.cpp | 13 +++++++------
----------------------------------------------------------------------------
diff --git a/src/apps/soundrecorder/TrackSlider.cpp
b/src/apps/soundrecorder/TrackSlider.cpp
index 9cbb606906..8689e5d4e0 100644
--- a/src/apps/soundrecorder/TrackSlider.cpp
+++ b/src/apps/soundrecorder/TrackSlider.cpp
@@ -64,13 +64,14 @@ TrackSlider::AttachedToWindow()
void
TrackSlider::_InitBitmap()
{
- if (fBitmapView) {
- fBitmap->RemoveChild(fBitmapView);
- delete fBitmapView;
- }
- if (fBitmap)
+ if (fBitmap != NULL) {
+ if (fBitmapView != NULL) {
+ fBitmap->RemoveChild(fBitmapView);
+ delete fBitmapView;
+ }
delete fBitmap;
-
+ }
+
BRect rect = Bounds();
fBitmap = new BBitmap(rect, BScreen().ColorSpace(), true);
