[haiku-commits] haiku: hrev53756 - src/add-ons/mail_daemon/inbound_protocols/imap/imap_lib

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 23 Jan 2020 12:03:07 -0500 (EST)

hrev53756 adds 1 changeset to branch 'master'
old head: eacbae702d4e2bda95c339d2bce0d1a4346d4033
new head: da3fe7140a31dc471d54bfb077cf93e62242cc95
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=da3fe7140a31+%5Eeacbae702d4e

----------------------------------------------------------------------------

da3fe7140a31: mail_daemon: Add missing throw
  
   Fix PVS V596
   Pointed out in PVS-Studio blog
   https://www.viva64.com/en/b/0644/
  
  Change-Id: Icf1f2d651dab84730fd348759ee7d19264ccbf75
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/2141
  Reviewed-by: Stephan Aßmus <superstippi@xxxxxx>

                                      [ Murai Takashi <tmurai01@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev53756
Commit:      da3fe7140a31dc471d54bfb077cf93e62242cc95
URL:         https://git.haiku-os.org/haiku/commit/?id=da3fe7140a31
Author:      Murai Takashi <tmurai01@xxxxxxxxx>
Date:        Wed Jan 15 12:06:39 2020 UTC
Committer:   Stephan Aßmus <superstippi@xxxxxx>
Commit-Date: Thu Jan 23 17:03:04 2020 UTC

----------------------------------------------------------------------------

1 file changed, 1 insertion(+), 1 deletion(-)
.../mail_daemon/inbound_protocols/imap/imap_lib/Response.cpp        | 2 +-

----------------------------------------------------------------------------

diff --git 
a/src/add-ons/mail_daemon/inbound_protocols/imap/imap_lib/Response.cpp 
b/src/add-ons/mail_daemon/inbound_protocols/imap/imap_lib/Response.cpp
index 8322c24e3c..1458badaa9 100644
--- a/src/add-ons/mail_daemon/inbound_protocols/imap/imap_lib/Response.cpp
+++ b/src/add-ons/mail_daemon/inbound_protocols/imap/imap_lib/Response.cpp
@@ -656,7 +656,7 @@ Response::ExtractNumber(BDataIO& stream)
        const char* end;
        size_t number = strtoul(string.String(), (char**)&end, 10);
        if (end == NULL || end[0] != '\0')
-               ParseException("Invalid number!");
+               throw ParseException("Invalid number!");
 
        return number;
 }


Other related posts:

  • » [haiku-commits] haiku: hrev53756 - src/add-ons/mail_daemon/inbound_protocols/imap/imap_lib - Stephan Aßmus