[haiku-commits] haiku: hrev53747 - src/tests/kits/app/bhandler

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 21 Jan 2020 19:27:34 -0500 (EST)

hrev53747 adds 1 changeset to branch 'master'
old head: 764345e18cb4bfb2e8a7bf082c9895605ff20bad
new head: e8b9c0e1a69fe9463b06fa1a10105480d38b55ea
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=e8b9c0e1a69f+%5E764345e18cb4

----------------------------------------------------------------------------

e8b9c0e1a69f: tests/BHandlerTester: Fix Perform1 test case
  
  TBHandlerTester::Perform1() tests the result of calling
  BHandler::Perform() with invalid input. On BeOS R5 this returns
  B_ERROR, but on Haiku this delegates to BArchivable::Perform(), which
  returns B_NAME_NOT_FOUND.
  Change-Id: Ia05220da4155a629cf611fec76da6477b9f1dbf4
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/2137
  Reviewed-by: Adrien Destugues <pulkomandy@xxxxxxxxx>

                                  [ Kyle Ambroff-Kao <kyle@xxxxxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev53747
Commit:      e8b9c0e1a69fe9463b06fa1a10105480d38b55ea
URL:         https://git.haiku-os.org/haiku/commit/?id=e8b9c0e1a69f
Author:      Kyle Ambroff-Kao <kyle@xxxxxxxxxxxxxx>
Date:        Tue Jan 21 00:55:03 2020 UTC
Committer:   waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Wed Jan 22 00:27:31 2020 UTC

----------------------------------------------------------------------------

1 file changed, 3 insertions(+), 3 deletions(-)
src/tests/kits/app/bhandler/BHandlerTester.cpp | 6 +++---

----------------------------------------------------------------------------

diff --git a/src/tests/kits/app/bhandler/BHandlerTester.cpp 
b/src/tests/kits/app/bhandler/BHandlerTester.cpp
index e215c56c27..4315217345 100644
--- a/src/tests/kits/app/bhandler/BHandlerTester.cpp
+++ b/src/tests/kits/app/bhandler/BHandlerTester.cpp
@@ -264,15 +264,15 @@ void TBHandlerTester::SetName2()
 
//------------------------------------------------------------------------------
 /**
        Perform(perform_code d, void *arg)
-       @case           feed meaningless data, should return B_ERROR
+       @case           feed meaningless data, should return B_NAME_NOT_FOUND
        @param  d       N/A
        @param  arg     NULL
-       @results        Returns B_ERROR
+       @results        Returns B_NAME_NOT_FOUND
  */
 void TBHandlerTester::Perform1()
 {
        BHandler Handler;
-       CPPUNIT_ASSERT(Handler.Perform(0, NULL) == B_ERROR);
+       CPPUNIT_ASSERT(Handler.Perform(0, NULL) == B_NAME_NOT_FOUND);
 }
 
//------------------------------------------------------------------------------
 /**


Other related posts:

  • » [haiku-commits] haiku: hrev53747 - src/tests/kits/app/bhandler - waddlesplash