[haiku-commits] haiku: hrev53587 - src/preferences/screensaver

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 22 Nov 2019 18:24:25 -0500 (EST)

hrev53587 adds 1 changeset to branch 'master'
old head: fb3493dfef07dcf61dbcf9d83557087e878e2179
new head: 2659cdba83dc62cbff17e5dc4f9691ccff8df8da
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=2659cdba83dc+%5Efb3493dfef07

----------------------------------------------------------------------------

2659cdba83dc: ScreenSaver prefs: Invoke list item runs test
  
  This copies the behavior of BeOS R5 ScreenSaver prefs.
  
  Don't invoke the listview on AllAttached() anymore, this would make
  the selected screensaver start when the pref window opens.
  
  Horizontally center the Test button.
  
  Change-Id: I65471112d37d9efd17945f05bce485ff2fece9dd
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/1958
  Reviewed-by: Adrien Destugues <pulkomandy@xxxxxxxxx>

                                     [ John Scipione <jscipione@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev53587
Commit:      2659cdba83dc62cbff17e5dc4f9691ccff8df8da
URL:         https://git.haiku-os.org/haiku/commit/?id=2659cdba83dc
Author:      John Scipione <jscipione@xxxxxxxxx>
Date:        Sat Nov 16 01:07:31 2019 UTC
Committer:   waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Fri Nov 22 23:24:22 2019 UTC

----------------------------------------------------------------------------

1 file changed, 3 insertions(+), 5 deletions(-)
src/preferences/screensaver/ScreenSaverWindow.cpp | 8 +++-----

----------------------------------------------------------------------------

diff --git a/src/preferences/screensaver/ScreenSaverWindow.cpp 
b/src/preferences/screensaver/ScreenSaverWindow.cpp
index 63bed647d7..5663e16a82 100644
--- a/src/preferences/screensaver/ScreenSaverWindow.cpp
+++ b/src/preferences/screensaver/ScreenSaverWindow.cpp
@@ -577,6 +577,8 @@ ModulesView::ModulesView(const char* name, 
ScreenSaverSettings& settings)
 
        fScreenSaversListView->SetSelectionMessage(
                new BMessage(kMsgSaverSelected));
+       fScreenSaversListView->SetInvocationMessage(
+               new BMessage(kMsgTestSaver));
        BScrollView* saversListScrollView = new BScrollView("scroll_list",
                fScreenSaversListView, 0, false, true);
 
@@ -592,10 +594,7 @@ ModulesView::ModulesView(const char* name, 
ScreenSaverSettings& settings)
                .AddGroup(B_VERTICAL)
                        .Add(fPreviewView)
                        .Add(saversListScrollView)
-                       .AddGroup(B_HORIZONTAL)
-                               .Add(fTestButton)
-                               .AddGlue()
-                               .End()
+                       .Add(fTestButton)
                        .End()
                .Add(fSettingsBox)
                .End();
@@ -634,7 +633,6 @@ void
 ModulesView::AllAttached()
 {
        PopulateScreenSaverList();
-       fScreenSaversListView->Invoke();
 }
 
 


Other related posts:

  • » [haiku-commits] haiku: hrev53587 - src/preferences/screensaver - waddlesplash