[haiku-commits] Re: haiku: hrev53490 - src/system/kernel/fs

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 19 Sep 2019 11:37:30 +0200

Am 15/09/2019 um 18:11 schrieb Adrien Destugues:

eff7baa89a2b: Revert "kernel/fs: Add missing IS_USER_ADDRESS check in 
user_vector_io."
   This reverts commit 2b5ebfcfd578f177968c5b923e5ccd6eb0195674.
Breaks cmake.
[...]
        ssize_t bytesTransferred = 0;
        for (uint32 i = 0; i < count; i++) {
-               if (!IS_USER_ADDRESS(vecs[i].iov_base)) {
-                       status = B_BAD_ADDRESS;
-                       if (bytesTransferred == 0)
-                               return status;
-                       break;
-               }

It would be nice to know how so. Maybe changing vecs[i].iov_len > 0 is enough to make this check work? Otherwise, it sounds like cmake is indeed broken, and needs to be stopped :-)

Bye,
   Axel.

Other related posts: