[haiku-commits] Re: haiku: hrev53395 - src/kits/game

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 30 Aug 2019 19:20:05 +0200

Am 27/08/2019 um 14:48 schrieb Ryan Leavengood:

On Tue, Aug 27, 2019 at 4:44 AM Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:

I'm a bit worried about this, or rather, the change that led to this one.
It appears to break binary compatibility. I just updated my system to a
revision that contains this, and my own app "theScheduler" crashes on
start, and the media server on shutdown.

Thinking about this more, I wonder if theSchedulder has the same issue
the Game Kit did, doing something that needed the PortPool before
creating the BMediaRoster? Without seeing the crashes it is hard to
know, but I seriously doubt this broke binary compatibility.

What should be changed is to create the PortPool on demand, as needed,
rather than needing the BMediaRoster. We can still destroy it in the
BMediaRosterUndertaker, or similar place.

Yes, something like that should work.

The app uses BMediaFiles::GetRefFor() in its BApplication constructor -- and it crashes because the PortPool doesn't exist yet.

But also, the media server crashed upon shutdown -- I don't know if that was just bad luck, or something new.


Other related posts: