[haiku-commits] Re: haiku: hrev53378 - in src: system/kernel/vm kits/media

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 16 Aug 2019 10:16:44 -0400

On Fri, Aug 16, 2019, 10:12 AM Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:

Hi Augustin,

Am 16/08/2019 um 06:31 schrieb waddlesplash:
Then, it may make sense to only dprintf() for userland areas for now (if
only because this would break compatibility otherwise), but for kernel
areas, I would insist on keeping the panic.
[...]
issues, too. Perhaps I should remove the KDEBUG guards now then?

Sorry, I completely misread that part - using dprintf() is perfectly
fine here. I somehow thought it would just allow it instead, and only
print a warning. But yes, I agree this warning could be printed without
KDEBUG turned on.

Then you can also disregard my comment about compatibility; it still
breaks compatibility by disallowing this :-)

That's definitely something to keep in mind when running old BeOS
applications. Maybe we want to set this flag for all areas of legacy
applications.


I already did that:
https://git.haiku-os.org/haiku/commit/?id=126d639908ff547b90158464582762ff06e85904

:)

-waddlesplash

Other related posts: