[haiku-commits] Re: haiku: hrev53368 - src/servers/media

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 13 Aug 2019 08:10:46 -0400

On Tue, Aug 13, 2019, 5:02 AM Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
wrote:

Hi,

-                       if (msg->FindInt32("team", &id) == B_OK
+                       if (msg->FindInt32("be:team", &id) == B_OK


This is a funny and nice catch that just shows how fragile this BMessage
model is.


No. The SOME_APP_QUIT message has had its members named so since the Be
days. This only shows you did not bother to test this code at all before
you committed it.

Cannot possibly fix the other issue with buffers.


Considering you were wrong about this issue, I am more than willing to bet
you are wrong about this, too.

-waddlesplash


Other related posts: