[haiku-commits] Re: haiku: hrev53344 - /

  • From: "Alexander von Gluck IV" <kallisti5@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 05 Aug 2019 23:16:43 +0000

August 5, 2019 4:54 PM, "waddlesplash" <waddlesplash@xxxxxxxxx> wrote:

Appears kallisti5 completely broke the notifier. Don't worry, master
is still fine; though there's now a hrev tag pointing to these
commits... I'll try to delete it.

-waddlesplash

On Mon, Aug 5, 2019 at 5:51 PM waddlesplash <waddlesplash@xxxxxxxxx> wrote:

hrev53344 adds 2 changesets to branch 'master'
old head: 7391b10ca5e1033ba2bf6ba6a35303b437b9077e
new head: 57d9a08982e5fc8be742cac87c50b4630709c499
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=57d9a08982e5+^7391b10ca5e1


Thanks :-)

So, the "big perl notifier" has been erroring out for a while and not-tagging 
things.

Turns out, gerrit submits a ref of "refs/changes/76/1223/meta" to the hooks 
while
the non-code-review one was a simple "refs/heads/(branch)"

All of the logic finding the branch was based around extracting the branch name
from the ref.. this is no longer a valid method to get it (causing the issues 
with
tags and notifications we have been seeing from gerrit code review accepted
commits)

I "fixed" the branch parsing, now we're "working" on the ref.

... except as you point out, the "ref" is what we're tagging now and logging.

Investigating.

 -- Alex

Other related posts: