[haiku-commits] Re: haiku: hrev53205 - build/jam/repositories/HaikuPorts src/add-ons/kernel/drivers/disk/nvme/compat

  • From: "Adrien Destugues" <pulkomandy@xxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 20 Jun 2019 06:35:32 +0000

Surely an #error would have been better here, else it'd be easy for it
to become forgotten for other platforms.

Except doing so would instantly break all other architecture builds... which 
is also not
ideal since nvme isn't essential at the moment on m68k, ppc, riscv64, etc.

Can't you use the jam stuff to filter out nvme on unsupported builds? We do 
this for a bunch of
other things

+1, if it doesn't work, don't build it. Just use nvme@x86,x86_64 in Jamfiles?

-- 
Adrien.


Other related posts: