[haiku-commits] haiku: hrev53166 - in src/apps: packageinstaller activitymonitor haikudepot/util

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 25 May 2019 14:38:39 -0400 (EDT)

hrev53166 adds 3 changesets to branch 'master'
old head: 70482896788d840019b7f92112b07fe0728f915c
new head: 94a67989c2963652f0e43305f13c535b1bc42eb7
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=94a67989c296+%5E70482896788d

----------------------------------------------------------------------------

f64ef4a3fd63: HaikuDepot: Add missing stdlib.h include to fix the build.

85200a1c4c07: ActivityMonitor: Add swap space to the default memory graph.
  
  I was doing some analysis of the memory areas the kernel was using
  after a long uptime, and found that there were 1.3GB worth of
  "slab area"s, but the kernel was "only" using 550MB according to
  ProcessController ... but then I realized I wasn't looking at
  swap, which showed another 700MB of usage.
  
  So, adding it to ActivityMonitor's main memory graph seems to
  make sense then. At least most Linux system monitors do this.

94a67989c296: LegacyPackageInstaller: The system name should be 
LegacyPackageInstaller.

                              [ Augustin Cavalier <waddlesplash@xxxxxxxxx> ]

----------------------------------------------------------------------------

4 files changed, 5 insertions(+), 3 deletions(-)
src/apps/activitymonitor/ActivityWindow.cpp     | 1 +
src/apps/haikudepot/util/LocaleUtils.cpp        | 3 ++-
src/apps/packageinstaller/PackageInstaller.rdef | 2 +-
src/apps/packageinstaller/PackageWindow.cpp     | 2 +-

############################################################################

Commit:      f64ef4a3fd63534e5d80a67b20c24f9cf717c779
URL:         https://git.haiku-os.org/haiku/commit/?id=f64ef4a3fd63
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Sat May 25 18:31:41 2019 UTC

HaikuDepot: Add missing stdlib.h include to fix the build.

----------------------------------------------------------------------------

diff --git a/src/apps/haikudepot/util/LocaleUtils.cpp 
b/src/apps/haikudepot/util/LocaleUtils.cpp
index d354aa7929..823f5697b6 100644
--- a/src/apps/haikudepot/util/LocaleUtils.cpp
+++ b/src/apps/haikudepot/util/LocaleUtils.cpp
@@ -4,6 +4,7 @@
  */
 #include "LocaleUtils.h"
 
+#include <stdlib.h>
 
 #include <Collator.h>
 #include <Locale.h>
@@ -33,4 +34,4 @@ LocaleUtils::GetCollator(BCollator* collator)
                debugger("unable to get the locale's collator");
                exit(EXIT_FAILURE);
        }
-}
\ No newline at end of file
+}

############################################################################

Commit:      85200a1c4c0705c3be921eac3d34a197eec2d041
URL:         https://git.haiku-os.org/haiku/commit/?id=85200a1c4c07
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Sat May 25 18:33:51 2019 UTC

ActivityMonitor: Add swap space to the default memory graph.

I was doing some analysis of the memory areas the kernel was using
after a long uptime, and found that there were 1.3GB worth of
"slab area"s, but the kernel was "only" using 550MB according to
ProcessController ... but then I realized I wasn't looking at
swap, which showed another 700MB of usage.

So, adding it to ActivityMonitor's main memory graph seems to
make sense then. At least most Linux system monitors do this.

----------------------------------------------------------------------------

diff --git a/src/apps/activitymonitor/ActivityWindow.cpp 
b/src/apps/activitymonitor/ActivityWindow.cpp
index f72794c161..5a65e870d5 100644
--- a/src/apps/activitymonitor/ActivityWindow.cpp
+++ b/src/apps/activitymonitor/ActivityWindow.cpp
@@ -366,6 +366,7 @@ ActivityWindow::_AddDefaultView()
                        // The first view defaults to memory usage
                        view->AddDataSource(new UsedMemoryDataSource());
                        view->AddDataSource(new CachedMemoryDataSource());
+                       view->AddDataSource(new SwapSpaceDataSource());
                        break;
                case 2:
                        // The third view defaults to network in/out

############################################################################

Revision:    hrev53166
Commit:      94a67989c2963652f0e43305f13c535b1bc42eb7
URL:         https://git.haiku-os.org/haiku/commit/?id=94a67989c296
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Sat May 25 18:37:29 2019 UTC

LegacyPackageInstaller: The system name should be LegacyPackageInstaller.

----------------------------------------------------------------------------

diff --git a/src/apps/packageinstaller/PackageInstaller.rdef 
b/src/apps/packageinstaller/PackageInstaller.rdef
index f9bc93248f..df8da2d13b 100644
--- a/src/apps/packageinstaller/PackageInstaller.rdef
+++ b/src/apps/packageinstaller/PackageInstaller.rdef
@@ -1,6 +1,6 @@
 resource app_signature "application/x-vnd.Haiku-PackageInstaller";
 
-resource app_name_catalog_entry "x-vnd.Haiku-PackageInstaller:System 
name:PackageInstaller";
+resource app_name_catalog_entry "x-vnd.Haiku-PackageInstaller:System 
name:LegacyPackageInstaller";
 
 resource file_types message {
        "types" = "application/x-scode-UPkg"
diff --git a/src/apps/packageinstaller/PackageWindow.cpp 
b/src/apps/packageinstaller/PackageWindow.cpp
index f73f8780c7..d534a7b430 100644
--- a/src/apps/packageinstaller/PackageWindow.cpp
+++ b/src/apps/packageinstaller/PackageWindow.cpp
@@ -25,7 +25,7 @@
 PackageWindow::PackageWindow(const entry_ref* ref)
        :
        BWindow(BRect(100, 100, 600, 300),
-               B_TRANSLATE_SYSTEM_NAME("PackageInstaller"),
+               B_TRANSLATE_SYSTEM_NAME("LegacyPackageInstaller"),
                B_TITLED_WINDOW, B_NOT_ZOOMABLE | B_AUTO_UPDATE_SIZE_LIMITS)
 {
        PackageView* view = new PackageView(ref);


Other related posts:

  • » [haiku-commits] haiku: hrev53166 - in src/apps: packageinstaller activitymonitor haikudepot/util - waddlesplash