[haiku-commits] Re: haiku: hrev53114 - src/libs/compat/freebsd_network
- From: waddlesplash <waddlesplash@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 14 May 2019 11:56:29 -0400
On Tue, May 14, 2019 at 11:53 AM Bruno Albuquerque <bga@xxxxxxxxxxxxx> wrote:
Look, this is now how it should work. If someone is working on a change that
person is most likely the one with full context on it and the one that can
more easily make sure it works. Just because a change is taking a while to be
merged (real life and all) unilaterally deciding it is ok to merge does not
seem reasonable at all. Technically any change being reviewed is work in
progress.
This is *SPECIALLY* important when considering we have virtually no test
coverage for a lot of things.
So, I would like to formally request that we do not do this. At the very
least, if you really want to submit a change, ask the author first. I do not
think this is unreasonable.
Like I noted yesterday, about 80-90% of changes on Gerrit in the last
year were *not* merged by the change author, but by some other
developer. So the workflow you are advocating here would be a complete
and total reversal of our current Gerrit policy.
Again, if you do not want a change merged yet, mark it WIP (you should
be able to do this via the git-review command line or the Gerrit web
interface), or add a -1/-2 from yourself. But requesting that only
change authors merge changes is not at all how we have chosen to use
Gerrit.
-waddlesplash
Other related posts:
