[haiku-commits] Re: haiku: hrev53104 - src/apps/debugger/user_interface/gui/team_window src/system/kernel/locks headers/private/kernel src/servers/debug
- From: waddlesplash <waddlesplash@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 2 May 2019 17:48:02 -0400
On Thu, May 2, 2019, 5:20 PM Jessica Hamilton <jessica.l.hamilton@xxxxxxxxx>
wrote:
#if KDEBUG
- if (lock->waiters != NULL && thread_get_current_thread_id()
- != lock->holder) {
- panic("mutex_destroy(): there are blocking threads, but
caller doesn't "
- "hold the lock (%p)", lock);
I don't understand why you removed the check for blocking threads.
Shouldn't we instead have both panics now?
A lock having no holder and blockling threads is an illegal state. The code
never does anything that would get us there, so this change will catch that
case still.
-waddlesplash
Other related posts:
