[haiku-commits] haiku: hrev52955 - headers/os/package/hpkg

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 3 Mar 2019 16:07:47 -0500 (EST)

hrev52955 adds 1 changeset to branch 'master'
old head: e573a0cfad3117235b965384a77fa2f8965496e7
new head: 752ec5c625d87dc6623bd3ddc9d67d97f7db9b9e
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=752ec5c625d8+%5Ee573a0cfad31

----------------------------------------------------------------------------

752ec5c625d8: Package kit: Fix -Werror=class-memaccess
  
  Initialize each class members instead of memset()
  for clearing PackageInfoAttributeValue.
  Pointed out by gcc8.
  
  Change-Id: I8bdb328e2271e49e840b1294dba9cca544805e72
  Reviewed-on: https://review.haiku-os.org/c/1114
  Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>

                                      [ Murai Takashi <tmurai01@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev52955
Commit:      752ec5c625d87dc6623bd3ddc9d67d97f7db9b9e
URL:         https://git.haiku-os.org/haiku/commit/?id=752ec5c625d8
Author:      Murai Takashi <tmurai01@xxxxxxxxx>
Date:        Mon Feb 25 12:12:11 2019 UTC
Committer:   waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Sun Mar  3 21:07:42 2019 UTC

----------------------------------------------------------------------------

1 file changed, 8 insertions(+), 1 deletion(-)
headers/os/package/hpkg/PackageInfoAttributeValue.h | 9 ++++++++-

----------------------------------------------------------------------------

diff --git a/headers/os/package/hpkg/PackageInfoAttributeValue.h 
b/headers/os/package/hpkg/PackageInfoAttributeValue.h
index 6e4a367d18..b75ab30525 100644
--- a/headers/os/package/hpkg/PackageInfoAttributeValue.h
+++ b/headers/os/package/hpkg/PackageInfoAttributeValue.h
@@ -123,7 +123,14 @@ BPackageInfoAttributeValue::SetTo(BPackageInfoAttributeID 
id,
 inline void
 BPackageInfoAttributeValue::Clear()
 {
-       memset(this, 0, sizeof(BPackageInfoAttributeValue));
+       unsignedInt = 0;
+       string = NULL;
+       version = {};
+       resolvable = {};
+       resolvableExpression = {};
+       globalWritableFileInfo = {};
+       userSettingsFileInfo = {};
+       user = {};
        attributeID = B_PACKAGE_INFO_ENUM_COUNT;
 }
 


Other related posts:

  • » [haiku-commits] haiku: hrev52955 - headers/os/package/hpkg - waddlesplash