[haiku-commits] haiku: hrev52940 - src/add-ons/media/media-add-ons/usb_webcam

  • From: Barrett17 <b.vitruvio@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 27 Feb 2019 18:10:39 -0500 (EST)

hrev52940 adds 1 changeset to branch 'master'
old head: 1d3959edfb0741a8a8ac768638133add307f8a19
new head: 88d7c7740aeb0812eeca9af704289479d6e1a3b4
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=88d7c7740aeb+%5E1d3959edfb07

----------------------------------------------------------------------------

88d7c7740aeb: media-add-ons/usb_webcam: Fix -Wclass-memaccess
  
  Remove memset(), since WebCamAddOn()::FillDefaultFlavorInfo()
  at next line sets all flavor_info members except _reserved_[].
  
  Change-Id: I41b4297a79303b61ccea914133b268b118b0d968
  Reviewed-on: https://review.haiku-os.org/c/1118
  Reviewed-by: Barrett17 <b.vitruvio@xxxxxxxxx>

                                      [ Murai Takashi <tmurai01@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev52940
Commit:      88d7c7740aeb0812eeca9af704289479d6e1a3b4
URL:         https://git.haiku-os.org/haiku/commit/?id=88d7c7740aeb
Author:      Murai Takashi <tmurai01@xxxxxxxxx>
Date:        Wed Feb 27 21:20:01 2019 UTC
Committer:   Barrett17 <b.vitruvio@xxxxxxxxx>
Commit-Date: Wed Feb 27 23:10:33 2019 UTC

----------------------------------------------------------------------------

1 file changed, 1 deletion(-)
src/add-ons/media/media-add-ons/usb_webcam/CamDevice.cpp | 1 -

----------------------------------------------------------------------------

diff --git a/src/add-ons/media/media-add-ons/usb_webcam/CamDevice.cpp 
b/src/add-ons/media/media-add-ons/usb_webcam/CamDevice.cpp
index 81d83fba02..140954d95c 100644
--- a/src/add-ons/media/media-add-ons/usb_webcam/CamDevice.cpp
+++ b/src/add-ons/media/media-add-ons/usb_webcam/CamDevice.cpp
@@ -47,7 +47,6 @@ CamDevice::CamDevice(CamDeviceAddon &_addon, BUSBDevice* 
_device)
          fLocker("WebcamDeviceLock")
 {
        // fill in the generic flavor
-       memset(&fFlavorInfo, 0, sizeof(fFlavorInfo));
        _addon.WebCamAddOn()->FillDefaultFlavorInfo(&fFlavorInfo);
        // if we use id matching, cache the index to the list
        if (fCamDeviceAddon.SupportedDevices()) {


Other related posts:

  • » [haiku-commits] haiku: hrev52940 - src/add-ons/media/media-add-ons/usb_webcam - Barrett17