[haiku-commits] haiku: hrev52781 - data/develop

  • From: humdinger <humdingerb@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 21 Jan 2019 10:56:44 -0500 (EST)

hrev52781 adds 1 changeset to branch 'master'
old head: ef916ff3b5680299e79d6cd2316daaecfe729ece
new head: a1f3d79db8e32db41056e941b95e02a3efd07ba7
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=a1f3d79db8e3+%5Eef916ff3b568

----------------------------------------------------------------------------

a1f3d79db8e3: makefile_engine: Revert hrev52738
  
  Reverts hrev52738, as discussed with waddlesplash on IRC.
  Re-opens #11419 "makefile_engine's install function fails on paths with 
blanks"
  
  Turns out this change results in escaped filenames, e.g. "Open Origin Package"
  becomes "Open\ Origin\ Package", see
  https://github.com/haikuports/haikuports/pull/3580

                                        [ Humdinger <humdingerb@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev52781
Commit:      a1f3d79db8e32db41056e941b95e02a3efd07ba7
URL:         https://git.haiku-os.org/haiku/commit/?id=a1f3d79db8e3
Author:      Humdinger <humdingerb@xxxxxxxxx>
Date:        Mon Jan 21 15:50:26 2019 UTC

Ticket:      https://dev.haiku-os.org/ticket/11419

----------------------------------------------------------------------------

1 file changed, 1 insertion(+), 1 deletion(-)
data/develop/makefile-engine | 2 +-

----------------------------------------------------------------------------

diff --git a/data/develop/makefile-engine b/data/develop/makefile-engine
index 21fccf6f18..7013a9a87d 100644
--- a/data/develop/makefile-engine
+++ b/data/develop/makefile-engine
@@ -366,7 +366,7 @@ ifeq ($(INSTALL_DIR), )
        @echo "No install directory specified for \"$(NAME)\" (INSTALL_DIR is 
empty)" >&2
 else
        mkdir -p "$(INSTALL_DIR)"
-       cp $(TARGET) "$(INSTALL_DIR)/$(NAME)"
+       cp $(TARGET) $(INSTALL_DIR)/$(NAME)
 endif
 
 # Set the catalog installation directory if it isn't already.


Other related posts:

  • » [haiku-commits] haiku: hrev52781 - data/develop - humdinger