hrev52779 adds 1 changeset to branch 'master'
old head: db578bfa3a13bf8588ea3a3e5f6dfb9c2f9a9e1d
new head: 2876fb7c18d9e31813e8f5f7d7bb90dd2b0851bd
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=2876fb7c18d9+%5Edb578bfa3a13
----------------------------------------------------------------------------
2876fb7c18d9: apps/DriveSetup Warn before formatting Intel extended Partition
* Provide a specific warning should a user select formatting the
intel extended partition. Formatting this partition results in
the loss of any subpartitions, and results in no usable partition.
(as described in bug #9856).
Change-Id: I6fb71f3329596217364f3be56b7ca225a1f26441
Reviewed-on: https://review.haiku-os.org/c/886
Reviewed-by: Stephan Aßmus <superstippi@xxxxxx>
[ Rob Gill <rrobgill@xxxxxxxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev52779
Commit: 2876fb7c18d9e31813e8f5f7d7bb90dd2b0851bd
URL: https://git.haiku-os.org/haiku/commit/?id=2876fb7c18d9
Author: Rob Gill <rrobgill@xxxxxxxxxxxxxx>
Date: Mon Jan 21 10:20:46 2019 UTC
Committer: Stephan Aßmus <superstippi@xxxxxx>
Commit-Date: Mon Jan 21 10:29:50 2019 UTC
Ticket: https://dev.haiku-os.org/ticket/9856
----------------------------------------------------------------------------
1 file changed, 7 insertions(+)
src/apps/drivesetup/MainWindow.cpp | 7 +++++++
----------------------------------------------------------------------------
diff --git a/src/apps/drivesetup/MainWindow.cpp
b/src/apps/drivesetup/MainWindow.cpp
index 165ac3007f..bd0417ff93 100644
--- a/src/apps/drivesetup/MainWindow.cpp
+++ b/src/apps/drivesetup/MainWindow.cpp
@@ -967,6 +967,7 @@ MainWindow::_Initialize(BDiskDevice* disk, partition_id
selectedPartition,
}
if (diskSystem.IsFileSystem()) {
+ BString intelExtendedPartition = "Intel Extended Partition";
if (disk->ID() == selectedPartition) {
snprintf(message, sizeof(message), B_TRANSLATE("Are you
sure you "
"want to format a raw disk? (Most people
initialize the disk "
@@ -978,6 +979,12 @@ MainWindow::_Initialize(BDiskDevice* disk, partition_id
selectedPartition,
"want to format the partition \"%s\"? You will
be asked "
"again before changes are written to the
disk."),
partition->ContentName());
+ } else if (partition->Type() == intelExtendedPartition) {
+ snprintf(message, sizeof(message), B_TRANSLATE("Are you
sure you "
+ "want to format the Intel Extended Partition?
Any "
+ "subpartitions it contains will be overwritten
if you "
+ "continue. You will be asked again before
changes are "
+ "written to the disk."));
} else {
snprintf(message, sizeof(message), B_TRANSLATE("Are you
sure you "
"want to format the partition? You will be
asked again "
