hrev52773 adds 3 changesets to branch 'master'
old head: 8fa626d09dfae368ab3c9ce0c3006629805309c4
new head: 450dd5db3a92361e41b7ffa2043659f724adfd55
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=450dd5db3a92+%5E8fa626d09dfa
----------------------------------------------------------------------------
205beac3821e: ArchitectureRules: Enable more warnings.
20f6556bffb9: kernel/x86: Backslash-escape trigraphs.
Fixes an instance of -Wtrigraphs.
450dd5db3a92: ACPI: Fix -Wunused-but-set-variable.
[ Augustin Cavalier <waddlesplash@xxxxxxxxx> ]
----------------------------------------------------------------------------
3 files changed, 10 insertions(+), 15 deletions(-)
build/jam/ArchitectureRules | 15 ++++++---------
.../kernel/bus_managers/acpi/EmbeddedController.cpp | 4 +---
src/system/kernel/arch/x86/arch_debug.cpp | 6 +++---
############################################################################
Commit: 205beac3821e0dc828851327495b498d91f07fee
URL: https://git.haiku-os.org/haiku/commit/?id=205beac3821e
Author: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date: Thu Jan 17 00:31:58 2019 UTC
ArchitectureRules: Enable more warnings.
----------------------------------------------------------------------------
diff --git a/build/jam/ArchitectureRules b/build/jam/ArchitectureRules
index d5ef98fbe3..7968ac9be2 100644
--- a/build/jam/ArchitectureRules
+++ b/build/jam/ArchitectureRules
@@ -112,18 +112,13 @@ rule ArchitectureSetup architecture
# set variables for gcc header options
SetIncludePropertiesVariables HAIKU : _$(architecture) ;
- # C/C++ flags
- if $(gccVersion[1]) >= 4 {
- HAIKU_C++FLAGS_$(architecture) += -Wno-deprecated ;
- }
-
# warning flags
HAIKU_WARNING_CCFLAGS_$(architecture) = -Wall
- -Wno-trigraphs -Wno-multichar
+ -Wno-multichar
-Wpointer-arith -Wcast-align -Wsign-compare
-Wmissing-prototypes ;
HAIKU_WARNING_C++FLAGS_$(architecture) = -Wall
- -Wno-trigraphs -Wno-multichar
+ -Wno-multichar
-Wpointer-arith -Wcast-align -Wsign-compare
-Wno-ctor-dtor-privacy -Woverloaded-virtual ;
@@ -138,8 +133,10 @@ rule ArchitectureSetup architecture
HAIKU_WERROR_FLAGS_$(architecture) = ;
if $(gccVersion[1]) >= 4 {
- # TODO: remove the -Wno-unused-but-set-variable option
- HAIKU_WERROR_FLAGS_$(architecture) +=
-Wno-error=unused-but-set-variable ;
+ # TODO: Remove all these.
+ HAIKU_WERROR_FLAGS_$(architecture) +=
-Wno-error=unused-but-set-variable
+ -Wno-error=deprecated -Wno-error=deprecated-declarations
+ -Wno-error=cpp -Wno-error=trigraphs ;
}
# debug flags
############################################################################
Commit: 20f6556bffb93794e2e2063f2b127a275dfc76d5
URL: https://git.haiku-os.org/haiku/commit/?id=20f6556bffb9
Author: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date: Thu Jan 17 00:32:16 2019 UTC
kernel/x86: Backslash-escape trigraphs.
Fixes an instance of -Wtrigraphs.
----------------------------------------------------------------------------
diff --git a/src/system/kernel/arch/x86/arch_debug.cpp
b/src/system/kernel/arch/x86/arch_debug.cpp
index 6bb1a4ed53..d864f0da58 100644
--- a/src/system/kernel/arch/x86/arch_debug.cpp
+++ b/src/system/kernel/arch/x86/arch_debug.cpp
@@ -183,7 +183,7 @@ print_demangled_call(const char* image, const char* symbol,
addr_t args,
kprintf("<%s> %.*s<\33[32m%#" B_PRIx32 "\33[0m>%s",
image,
namespaceLength, name, argValue, lastName);
} else
- kprintf("<%s> %.*s<???>%s", image, namespaceLength,
name, lastName);
+ kprintf("<%s> %.*s<\?\?\?>%s", image, namespaceLength,
name, lastName);
if (addDebugVariables)
set_debug_variable("_this", argValue);
@@ -299,7 +299,7 @@ print_demangled_call(const char* image, const char* symbol,
addr_t args,
kprintf(" \33[31m\"<NULL>\"\33[0m");
else if (debug_strlcpy(B_CURRENT_TEAM, buffer,
(char*)(addr_t)value,
kBufferSize) < B_OK) {
- kprintf(" \33[31m\"<???>\"\33[0m");
+ kprintf(" \33[31m\"<\?\?\?>\"\33[0m");
} else
kprintf(" \33[36m\"%s\"\33[0m", buffer);
}
@@ -1172,7 +1172,7 @@ arch_debug_get_stack_trace(addr_t* returnAddresses, int32
maxCount,
break;
}
}
-
+
if (ip == 0)
break;
############################################################################
Revision: hrev52773
Commit: 450dd5db3a92361e41b7ffa2043659f724adfd55
URL: https://git.haiku-os.org/haiku/commit/?id=450dd5db3a92
Author: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date: Thu Jan 17 00:32:45 2019 UTC
ACPI: Fix -Wunused-but-set-variable.
----------------------------------------------------------------------------
diff --git a/src/add-ons/kernel/bus_managers/acpi/EmbeddedController.cpp
b/src/add-ons/kernel/bus_managers/acpi/EmbeddedController.cpp
index ca13bf19c0..011da58345 100644
--- a/src/add-ons/kernel/bus_managers/acpi/EmbeddedController.cpp
+++ b/src/add-ons/kernel/bus_managers/acpi/EmbeddedController.cpp
@@ -729,11 +729,9 @@ EcWaitEvent(struct acpi_ec_cookie* sc, EC_EVENT event,
int32 generationCount)
// status register each time we get one. It's possible to get a
// GPE for an event we're not interested in here (i.e., SCI for
// EC query).
- status_t waitStatus = B_NO_ERROR;
for (i = 0; i < ec_timeout; i++) {
if (generationCount == sc->ec_gencount) {
- waitStatus =
-
sc->ec_condition_var.Wait(B_RELATIVE_TIMEOUT, 1000);
+ sc->ec_condition_var.Wait(B_RELATIVE_TIMEOUT,
1000);
}
/*
* Record new generation count. It's possible the GPE
was
