hrev52669 adds 1 changeset to branch 'master'
old head: a62458c79c8ea57944edd84c23450b1425f616b9
new head: cdb7e8177dc48718d1577edd9b184f821ff0fa3b
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=cdb7e8177dc4+%5Ea62458c79c8e
----------------------------------------------------------------------------
cdb7e8177dc4: media-add-ons/multi_audio: Remove unneed menset()
Remove unneed menset(), since media_format already use memset()
in its constructor.
Also fixes -Werror=class-memaccess pointed out by gcc8.
Change-Id: I3283417323550492799a34a2d29cdad03a82a2d5
Reviewed-on: https://review.haiku-os.org/783
Reviewed-by: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
[ Murai Takashi <tmurai01@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev52669
Commit: cdb7e8177dc48718d1577edd9b184f821ff0fa3b
URL: https://git.haiku-os.org/haiku/commit/?id=cdb7e8177dc4
Author: Murai Takashi <tmurai01@xxxxxxxxx>
Date: Sat May 19 00:30:47 2018 UTC
Committer: Jérôme Duval <jerome.duval@xxxxxxxxx>
Commit-Date: Thu Dec 20 09:00:31 2018 UTC
----------------------------------------------------------------------------
1 file changed, 2 insertions(+), 5 deletions(-)
src/add-ons/media/media-add-ons/multi_audio/MultiAudioNode.cpp | 7 ++-----
----------------------------------------------------------------------------
diff --git a/src/add-ons/media/media-add-ons/multi_audio/MultiAudioNode.cpp
b/src/add-ons/media/media-add-ons/multi_audio/MultiAudioNode.cpp
index d28d9d447f..69d1819a7b 100644
--- a/src/add-ons/media/media-add-ons/multi_audio/MultiAudioNode.cpp
+++ b/src/add-ons/media/media-add-ons/multi_audio/MultiAudioNode.cpp
@@ -195,8 +195,6 @@ MultiAudioNode::MultiAudioNode(BMediaAddOn* addon, const
char* name,
AddNodeKind(B_PHYSICAL_INPUT);
// initialize our preferred format objects
- memset(&fOutputPreferredFormat, 0, sizeof(fOutputPreferredFormat));
- // set everything to wildcard first
fOutputPreferredFormat.type = B_MEDIA_RAW_AUDIO;
fOutputPreferredFormat.u.raw_audio.format
= MultiAudio::convert_to_media_format(
@@ -218,8 +216,6 @@ MultiAudioNode::MultiAudioNode(BMediaAddOn* addon, const
char* name,
* fOutputPreferredFormat.u.raw_audio.channel_count;
// initialize our preferred format objects
- memset(&fInputPreferredFormat, 0, sizeof(fInputPreferredFormat));
- // set everything to wildcard first
fInputPreferredFormat.type = B_MEDIA_RAW_AUDIO;
fInputPreferredFormat.u.raw_audio.format
= MultiAudio::convert_to_media_format(
@@ -228,7 +224,8 @@ MultiAudioNode::MultiAudioNode(BMediaAddOn* addon, const
char* name,
=
MultiAudio::convert_to_valid_bits(fDevice->FormatInfo().input.format);
fInputPreferredFormat.u.raw_audio.channel_count = 2;
fInputPreferredFormat.u.raw_audio.frame_rate
- =
MultiAudio::convert_to_sample_rate(fDevice->FormatInfo().input.rate);
// measured in Hertz
+ =
MultiAudio::convert_to_sample_rate(fDevice->FormatInfo().input.rate);
+ // measured in Hertz
fInputPreferredFormat.u.raw_audio.byte_order = B_MEDIA_HOST_ENDIAN;
// we'll use the consumer's preferred buffer size, if any
