[haiku-commits] Re: haiku: hrev52666 - src/servers/net
- From: "Alexander von Gluck IV" <kallisti5@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 19 Dec 2018 14:08:38 +0000
December 19, 2018 7:23 AM, "waddlesplash" <waddlesplash@xxxxxxxxx
(mailto:waddlesplash@xxxxxxxxx?to=%22waddlesplash%22%20<waddlesplash@xxxxxxxxx>)>
wrote:
On Wed, Dec 19, 2018, 8:18 AM Axel Dörfler <axeld@xxxxxxxxxxxxxxxx
(mailto:axeld@xxxxxxxxxxxxxxxx) wrote: Am 19.12.2018 um 13:38 schrieb
kallisti5@xxxxxxxxxxx (mailto:kallisti5@xxxxxxxxxxx):
Woah, I did extensive testing with multiple nics(documented in original
review) and never saw this.
Could you provide more details about your testing steps?
Two nics, first one with a static configuration, the other one left
blank in the "interfaces" file.
With the patch applied, both nics will get auto-configured. And looking
at the sources, I cannot really see how it would not do that. Except the
staticly configured NIC got its static IP from the configuration file, as
expected, not auto-configured... Note that there is also
https://dev.haiku-os.org/ticket/14626 ;(
https://dev.haiku-os.org/ticket/14626)
which may be related here. -waddlesplash
Ah. Yup. Swap my ordering around to be alphabetical:
* /dev/net/emulex_oce/0 - Static configurd
* /dev/net/emulex_oce/1 - no link
* /dev/net/rtl81xx/0 - DHCP address
I bet Axel's alphabetical nic layout is:
* 1st nic DHCP
* 2nd nic Static
Given the original code wouldn't activate the first NIC if the second one was
configured,
his configuration file would of applied to the second NIC due to #14626
Once all nic's were added to the net_server, the static configuration applied
to the 1st instead.
So, the updated change was good as long as #14626 is fixed :-)
-- Alex
Other related posts:
