hrev52631 adds 1 changeset to branch 'master'
old head: dbbac3316361f70438ff3e2ff1c1d0532731620b
new head: f232d9d22c2f003e14cb95bbd6d6785551c00ebf
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=f232d9d22c2f+%5Edbbac3316361
----------------------------------------------------------------------------
f232d9d22c2f: AboutSystem: Minor fix for opening links
It looks like it unfolds to:
> /bin/open /bin/open https://www.example.com
Instead of the expected:
> /bin/open https://www.example.com
See "src/kits/app/Roster.cpp", BRoster::ArgVector::Init() method:
// init vector
if (error == B_OK) {
fArgs[0] = fAppPath.Path(); // Here
if (argc > 0 && args != NULL) {
for (int i = 0; i < argc; i++)
fArgs[i + 1] = args[i];
if (hasDocArg)
fArgs[fArgc - 1] = fDocPath.Path();
}
// NULL terminate (e.g. required by load_image())
fArgs[fArgc] = NULL;
}
Change-Id: Ie7e7155377637b93cbc3c1d225cb91b5e0d2dd7d
Reviewed-on: https://review.haiku-os.org/754
Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>
[ EXL <exlmotodev@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev52631
Commit: f232d9d22c2f003e14cb95bbd6d6785551c00ebf
URL: https://git.haiku-os.org/haiku/commit/?id=f232d9d22c2f
Author: EXL <exlmotodev@xxxxxxxxx>
Date: Sun Dec 9 02:23:20 2018 UTC
Committer: waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Sun Dec 9 19:33:55 2018 UTC
----------------------------------------------------------------------------
1 file changed, 2 insertions(+), 3 deletions(-)
src/apps/aboutsystem/HyperTextActions.cpp | 5 ++---
----------------------------------------------------------------------------
diff --git a/src/apps/aboutsystem/HyperTextActions.cpp
b/src/apps/aboutsystem/HyperTextActions.cpp
index 5c8770ca26..be45453d06 100644
--- a/src/apps/aboutsystem/HyperTextActions.cpp
+++ b/src/apps/aboutsystem/HyperTextActions.cpp
@@ -33,9 +33,8 @@ URLAction::Clicked(HyperTextView* view, BPoint where,
BMessage* message)
if (get_ref_for_path("/bin/open", &ref))
return;
- const char* args[] = { "/bin/open", fURL.String(), NULL };
- be_roster->Launch(&ref, 2, args);
-
+ const char* args[] = { fURL.String(), NULL };
+ be_roster->Launch(&ref, 1, args);
}
