hrev52622 adds 1 changeset to branch 'master'
old head: 652a4674d4fba7122261eb1412924ce7951fcb3c
new head: f8278c1398e9310842d3e36e494af6422253e2bb
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=f8278c1398e9+%5E652a4674d4fb
----------------------------------------------------------------------------
f8278c1398e9: codycam: Fix PVS 1321
Fix local variable 'fSettingsDir' is same name as Settings class member
'fSettingsDir'.
https://git.haiku-os.org/haiku/tree/src/apps/codycam/SettingsHandler.h#n148
Change-Id: Ifa12b3239e88bf1f7f29c77704ea1f9f161384f7
Reviewed-on: https://review.haiku-os.org/752
Reviewed-by: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Reviewed-by: Stephan Aßmus <superstippi@xxxxxx>
[ Murai Takashi <tmurai01@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev52622
Commit: f8278c1398e9310842d3e36e494af6422253e2bb
URL: https://git.haiku-os.org/haiku/commit/?id=f8278c1398e9
Author: Murai Takashi <tmurai01@xxxxxxxxx>
Date: Sun Dec 2 21:23:00 2018 UTC
Committer: Stephan Aßmus <superstippi@xxxxxx>
Commit-Date: Tue Dec 4 12:30:53 2018 UTC
----------------------------------------------------------------------------
1 file changed, 4 insertions(+), 4 deletions(-)
src/apps/codycam/SettingsHandler.cpp | 8 ++++----
----------------------------------------------------------------------------
diff --git a/src/apps/codycam/SettingsHandler.cpp
b/src/apps/codycam/SettingsHandler.cpp
index c04c2566e4..4641a370c3 100644
--- a/src/apps/codycam/SettingsHandler.cpp
+++ b/src/apps/codycam/SettingsHandler.cpp
@@ -435,15 +435,15 @@ Settings::_MakeSettingsDirectory(BDirectory
*resultingSettingsDir)
void
Settings::_SaveCurrentSettings(bool onlyIfNonDefault)
{
- BDirectory fSettingsDir;
- _MakeSettingsDirectory(&fSettingsDir);
+ BDirectory settingsDir;
+ _MakeSettingsDirectory(&settingsDir);
- if (fSettingsDir.InitCheck() != B_OK)
+ if (settingsDir.InitCheck() != B_OK)
return;
printf("+++++++++++ Settings::_SaveCurrentSettings %s\n", fFileName);
// nuke old settings
- BEntry entry(&fSettingsDir, fFileName);
+ BEntry entry(&settingsDir, fFileName);
entry.Remove();
BFile prefs(&entry, O_RDWR | O_CREAT);
