[haiku-commits] Re: haiku: hrev52572 - build/jam

  • From: Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 25 Nov 2018 10:41:50 +0100

On Fri, Nov 23, 2018 at 6:58 PM Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
wrote:



On Fri, Nov 23, 2018 at 6:51 PM Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
wrote:

It seems the ape_reader is broken on x86_64 since last commits:

C++
objects/haiku/x86_64/release/add-ons/media/plugins/ape_reader/MAClib/APECompress.o
In file included from
../src/add-ons/media/plugins/ape_reader/MAClib/APECompress.h:4:0,
                 from
../src/add-ons/media/plugins/ape_reader/MAClib/APECompress.cpp:2:
../src/add-ons/media/plugins/ape_reader/MAClib/MACLib.h:87:54: error:
'__stdcall__' attribute ignored [-Werror=attributes]
 typedef void (__stdcall * APE_PROGRESS_CALLBACK) (int);


Not sure what changed in the buildsystem, but besides the deprecated
attribute, there are various errors that may affect other parts of the
system I guess.


It seems I forgot that ape_reader isn't enabled on x86_64. However I tried
to fix it, and after fixing the build errors I discovered there's a piece
of asm.
So, I tried to update the maclib, but the madness of this code was too
 big, and gave up after a few attempts. It is indeed possible to get this
code running, but if someone want to try in future I suggest to go directly
updating the MACLib.

-- 
Saluti,
Dario

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 11-2018