[haiku-commits] Re: haiku: hrev52545 - src/add-ons/kernel/drivers/network/wlan/idualwifi7260/dev/iwm

  • From: Rene Gollent <anevilyak@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 17 Nov 2018 15:46:22 -0500

On Sat, Nov 17, 2018 at 2:59 PM waddlesplash <waddlesplash@xxxxxxxxx> wrote:


hrev52545 adds 1 changeset to branch 'master'
old head: 01304f19fda9332128ec65b675c7d88c01b471e2
new head: a54cdaa07af405f4786b48f0ab6365a366c9ed71
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=a54cdaa07af4+%5E01304f19fda9

----------------------------------------------------------------------------

a54cdaa07af4: idualwifi7260: Fix a different instance of memset(NULL).

[...]

diff --git 
a/src/add-ons/kernel/drivers/network/wlan/idualwifi7260/dev/iwm/if_iwm.c 
b/src/add-ons/kernel/drivers/network/wlan/idualwifi7260/dev/iwm/if_iwm.c
index 11094cd6f2..dfd598f478 100644
--- a/src/add-ons/kernel/drivers/network/wlan/idualwifi7260/dev/iwm/if_iwm.c
+++ b/src/add-ons/kernel/drivers/network/wlan/idualwifi7260/dev/iwm/if_iwm.c
@@ -539,8 +539,7 @@ iwm_fw_info_free(struct iwm_fw_info *fw)
        firmware_put(fw->fw_fp, FIRMWARE_UNLOAD);
        fw->fw_fp = NULL;
        /* don't touch fw->fw_status */
-       if (fw->fw_sects)
-               memset(fw->fw_sects, 0, sizeof(fw->fw_sects));
+       memset(fw->fw_sects, 0, sizeof(fw->fw_sects));
 }

Is it intentional that this appears to have undone your previous commit?

Regards,

Rene

Other related posts: