hrev52335 adds 1 changeset to branch 'master'
old head: 74e882b39b3f584a1c8e73c91ab5bbcd3c81eaa5
new head: 81d0a0e0a76f3d7188b5ea318c2f1540e1b210e9
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=81d0a0e0a76f+%5E74e882b39b3f
----------------------------------------------------------------------------
81d0a0e0a76f: BColumnListView: Always update the reference rect in
::FindVisibleRect...
...if the row is present in the list, but continue to return false if the
row is not currently visible on the screen.
Part of #11675. Cherry-picked from https://review.haiku-os.org/442.
[ David Murphy <murphman@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev52335
Commit: 81d0a0e0a76f3d7188b5ea318c2f1540e1b210e9
URL: https://git.haiku-os.org/haiku/commit/?id=81d0a0e0a76f
Author: David Murphy <murphman@xxxxxxxxx>
Date: Tue Sep 11 20:51:27 2018 UTC
Committer: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Commit-Date: Tue Sep 11 22:59:32 2018 UTC
Ticket: https://dev.haiku-os.org/ticket/11675
----------------------------------------------------------------------------
1 file changed, 1 insertion(+), 3 deletions(-)
src/kits/interface/ColumnListView.cpp | 4 +---
----------------------------------------------------------------------------
diff --git a/src/kits/interface/ColumnListView.cpp
b/src/kits/interface/ColumnListView.cpp
index 2c0ed08e2a..0c0dc8627b 100644
--- a/src/kits/interface/ColumnListView.cpp
+++ b/src/kits/interface/ColumnListView.cpp
@@ -4561,13 +4561,11 @@ OutlineView::FindVisibleRect(BRow* row, BRect* _rect)
float line = 0.0;
for (RecursiveOutlineIterator iterator(&fRows);
iterator.CurrentRow();
iterator.GoToNext()) {
- if (line > fVisibleRect.bottom)
- break;
if (iterator.CurrentRow() == row) {
_rect->Set(fVisibleRect.left, line,
fVisibleRect.right,
line + row->Height());
- return true;
+ return line <= fVisibleRect.bottom;
}
line += iterator.CurrentRow()->Height() + 1;