[haiku-commits] Re: haiku: hrev52159 - src/servers/app/font docs/interface_guidelines src/kits/network/libnetapi src/servers/app

  • From: Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 2 Aug 2018 14:03:31 +0200

It's correct that Appearance does not test IsFullAndHalfFixed. A full and
half fixed font cannot be used in place of a fixed font, it needs special
handling, as in Terminal


Il giorno gio 2 ago 2018 alle ore 13:54 waddlesplash <waddlesplash@xxxxxxxxx>
ha scritto:

On Thu, Aug 2, 2018, 6:44 AM Jérôme Duval <jerome.duval@xxxxxxxxx> wrote:

hrev52159 adds 2 changesets to branch 'master'
old head: 20694a04585f349f3815d13c1fbbccee66c782d6
new head: b2acee1cb986b696adfad7daabfe9279949a3e54
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=b2acee1cb986+%5E20694a04585f


----------------------------------------------------------------------------

d9eeaa720a72: Server side support for BFont::IsFullAndHalfFixed().

  Check a range of characters to see if they have the same width.

  Change-Id: I9cef12f78d1e1d01acc6284eae90dbfb86166fc6
  Reviewed-on: https://review.haiku-os.org/47
  Reviewed-by: Adrien Destugues <pulkomandy@xxxxxxxxx>
  Reviewed-by: Jérôme Duval <jerome.duval@xxxxxxxxx>

                       [ Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx>
]

b2acee1cb986: Switch default fixed font from NotoMono to NotoSansMono

  Change-Id: Ib9eab5a2e266393b234cf7f4a6934fd58e31c943
  Reviewed-on: https://review.haiku-os.org/48
  Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>
  Reviewed-by: Jérôme Duval <jerome.duval@xxxxxxxxx>

                                        [ Humdinger <humdingerb@xxxxxxxxx>
]

----------------------------


As humdinger commented in the ticket, switching the default fixed font
does not work even with the patch because Appearance settings do not test
IsFullAndHalfFixed. Was this tested?

-waddlesplash


Other related posts: