[haiku-commits] Re: haiku: hrev52133 - src/apps/mediaconverter
- From: Jérôme Duval <jerome.duval@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 25 Jul 2018 18:40:19 +0200
2018-07-25 18:06 GMT+02:00 Dario Casalinuovo <b.vitruvio@xxxxxxxxx>:
In any case I expect people to review correctly, in this case it seems 3
devs accepted code they didn't understand.
I think the patch is still an improvement over the previous
MediaConverter code, as it replaced a function (memset) with its
equivalent, thus making it cleaner. At least it's consistent with the
precedent patch.
Your last one suggestion was to make these new functions private. I'm
sure everyone will be pleased to review your rework of this when you
find time for it.
Bye,
Jérôme
Other related posts:
