[haiku-commits] Re: haiku: hrev52133 - src/apps/mediaconverter
- From: John Scipione <jscipione@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 25 Jul 2018 08:37:48 -0700
On Wed, Jul 25, 2018, 6:46 AM Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
wrote:
Again, I do not agree with that. Already explained clearly why in IRC.
I ask to revert this ugly stuff, or I will do it myself.
From 52133:
What's the reason for adding this half-done API?
And even in the end we have the same TODO "we should not!!! make flat
copies of media_format".
Why you add "Clear" in place of memset, then replace memset with clear in
the code?
We are trying to avoid adding new media_kit API, for the reasons stated one
hundred times, please make this commit to fix something or keep the API
clean.
I don't have a big problem with the Clear() and Flatten() methods but it
sounds like Dario's complaint is that the API encourages the use of a flat
data structure and that we should avoid changing the API and code until we
have had the chance to create better data structures.
Other related posts:
