[haiku-commits] Re: haiku: hrev52029 - in src: add-ons/kernel/bus_managers/acpi kits/interface servers/app kits/debugger/ids kits/debugger/elf
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 22 Jun 2018 08:56:05 +0200
Am 22/06/2018 um 05:24 schrieb waddlesplash:
4215eb6003c8: Debugger: Fix some broken comparisons.
Actually weird, not really broken :-)
// magic
- if (!memcmp(elfIdent, ELFMAG, 4) == 0)
+ if (!(memcmp(elfIdent, ELFMAG, 4) == 0))
return B_ERROR;
I'd very much prefer to get rid of the ! at all for readability:
if (memcmp(elfIdent, ELFMAG, 4) != 0)
Bye,
Axel.
Other related posts: