[haiku-commits] Re: haiku: hrev51536 - src/add-ons/kernel/busses/usb

  • From: Fredrik Holmqvist <fredrik.holmqvist@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 08 Nov 2017 22:20:47 +0000

Nice. Here is some syslog usb trace outtake for EHCI/XHCI on my system
after this commit. Let me know if I can help with anything

 https://gist.github.com/tqh/9223b4be55b715a2da06bdbb5fbce53d

/Fredrik Holmqvist, TQH


ons 8 nov. 2017 kl 22:47 skrev <jerome.duval@xxxxxxxxx>:

hrev51536 adds 1 changeset to branch 'master'
old head: c5ea0115b0c2bd8a2726f47443b71b5c5e446079
new head: fd6ef33795c1c3a32975a300ee024117cb7f3f15
overview:
http://cgit.haiku-os.org/haiku/log/?qt=range&q=fd6ef33795c1+%5Ec5ea0115b0c2


----------------------------------------------------------------------------

fd6ef33795c1: xhci: HandleTransferComplete: adjust the lower check.

  after the previous commit.

                                   [ Jérôme Duval <jerome.duval@xxxxxxxxx>
]


----------------------------------------------------------------------------

Revision:    hrev51536
Commit:      fd6ef33795c1c3a32975a300ee024117cb7f3f15
URL:         http://cgit.haiku-os.org/haiku/commit/?id=fd6ef33795c1
Author:      Jérôme Duval <jerome.duval@xxxxxxxxx>
Date:        Wed Nov  8 21:37:25 2017 UTC


----------------------------------------------------------------------------

1 file changed, 1 insertion(+), 1 deletion(-)
src/add-ons/kernel/busses/usb/xhci.cpp | 2 +-


----------------------------------------------------------------------------

diff --git a/src/add-ons/kernel/busses/usb/xhci.cpp
b/src/add-ons/kernel/busses/usb/xhci.cpp
index f50993e..5613f94 100644
--- a/src/add-ons/kernel/busses/usb/xhci.cpp
+++ b/src/add-ons/kernel/busses/usb/xhci.cpp
@@ -2066,7 +2066,7 @@ XHCI::HandleTransferComplete(xhci_trb* trb)
                        TRACE("HandleTransferComplete td %p offset %"
B_PRId64 " %"
                                B_PRIxADDR "\n", td_chain, offset, source);
                        offset = offset / sizeof(xhci_trb) + 1;
-                       if (offset <= td_chain->trb_count && offset >= 0) {
+                       if (offset <= td_chain->trb_count && offset >= 1) {
                                TRACE("HandleTransferComplete td %p trb %"
B_PRId64 " found "
                                        "\n", td_chain, offset);
                                // is it the last trb?



Other related posts: