[haiku-commits] haiku: hrev51359 - src/apps/webpositive

  • From: pulkomandy@xxxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 13 Aug 2017 08:02:32 +0200 (CEST)

hrev51359 adds 1 changeset to branch 'master'
old head: d7842252373a6fc337417e396c3ce1092f0b16eb
new head: 433447be2197979b2030cc87838643309cceeb45
overview: 
http://cgit.haiku-os.org/haiku/log/?qt=range&q=433447be2197+%5Ed7842252373a

----------------------------------------------------------------------------

433447be2197: WebPositive: hangs when cookie jar is corrupt.
  
  Missing error check led to endless loop trying to extract cookies from
  an invalid message. Now the cookie jar is left empty instead.

                             [ Adrien Destugues <pulkomandy@xxxxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev51359
Commit:      433447be2197979b2030cc87838643309cceeb45
URL:         http://cgit.haiku-os.org/haiku/commit/?id=433447be2197
Author:      Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Date:        Sun Aug 13 05:59:11 2017 UTC

----------------------------------------------------------------------------

1 file changed, 4 insertions(+), 2 deletions(-)
src/apps/webpositive/BrowserApp.cpp | 6 ++++--

----------------------------------------------------------------------------

diff --git a/src/apps/webpositive/BrowserApp.cpp 
b/src/apps/webpositive/BrowserApp.cpp
index 0b4df79..f7f0ddf 100644
--- a/src/apps/webpositive/BrowserApp.cpp
+++ b/src/apps/webpositive/BrowserApp.cpp
@@ -89,9 +89,11 @@ BrowserApp::BrowserApp()
        cookieStorePath << "/Cookies";
        fCookies = new SettingsMessage(B_USER_SETTINGS_DIRECTORY,
                cookieStorePath.String());
-       BMessage cookieArchive = fCookies->GetValue("cookies", cookieArchive);
        fContext = new BUrlContext();
-       fContext->SetCookieJar(BNetworkCookieJar(&cookieArchive));
+       if (fCookies->InitCheck() == B_OK) {
+               BMessage cookieArchive = fCookies->GetValue("cookies", 
cookieArchive);
+               fContext->SetCookieJar(BNetworkCookieJar(&cookieArchive));
+       }
 #endif
 
        BString sessionStorePath = kApplicationName;


Other related posts:

  • » [haiku-commits] haiku: hrev51359 - src/apps/webpositive - pulkomandy