[haiku-commits] Re: haiku: hrev51344 - src/apps/networkstatus

  • From: kallisti5 <kallisti5@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 03 Aug 2017 13:08:32 -0500

On 2017-08-03 07:47, philippe.houdoin@xxxxxxxxx wrote:

hrev51344 adds 1 changeset to branch 'master'
old head: 65abebfaa73cc5833b38358e5d281a8f05914018
new head: cb7833c724482020aee37ec624db0f8705c5eff4
overview:
http://cgit.haiku-os.org/haiku/log/?qt=range&q=cb7833c72448+%5E65abebfaa73c

[ Philippe Houdoin <philippe.houdoin@xxxxxxxxx> ]

diff --git a/src/apps/networkstatus/NetworkStatusView.cpp
b/src/apps/networkstatus/NetworkStatusView.cpp
index 2495f3b..1062bc8 100644
--- a/src/apps/networkstatus/NetworkStatusView.cpp
+++ b/src/apps/networkstatus/NetworkStatusView.cpp

+       if ((flags & (IFF_UP | IFF_LINK | IFF_CONFIGURING)) == IFF_LINK)
+               return kStatusLinkNoConfig;

Wait... am I crazy or does this not make sense?

  this:            X & (IFF_UP | IFF_LINK | IFF_CONFIGURING) == IFF_LINK
  reduces to this: X & (IFF_LINK) == IFF_LINK

Masking for IFF_UP and IFF_CONFIGURING doesn't really do anything.


Maybe you meant:

  X & (IFF_UP | IFF_LINK | IFF_CONFIGURING) != 0   ?

 -- Alex

Other related posts: