[haiku-commits] Re: haiku: hrev51089 - src/servers/launch
- From: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 11 Apr 2017 07:18:34 +0200
On Mon, Apr 10, 2017 at 11:33:33PM +0200, Axel Dörfler wrote:
create_directory(path, 0777);
status_t status = entry.SetTo(path);
Shouldn't this also verify create_directory's return? Otherwise, doesn't
the SetTo right afterwards potentially not catch the same problem as the
initial InitCheck?
Yes indeed. But since the system doesn't seem to mind anyway, it doesn't
seem to be that important ;-)
Should still be fixed, though...
What to do if it fails? It looks like none of the code executed would
have any effect except for logging (which goes to /dev/null in release
builds). So we will run with the directory missing, but it has been that
way since the retirement of the BootScript and it did not seem to cause
that much problems.
--
Adrien.
Other related posts:
